agorise/graphenej
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Calling onFailure method in case the parsed response comes with a non-null error object

Browse source
This commit is contained in:
Nelson R. Pérez 2019-12-03 12:39:42 -05:00
parent a8c13cac96
commit bba825ca62
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
graphenej/src/main/java/cy/agorise/graphenej/api/ApiCallback.java
View file

@ -1,5 +1,7 @@
package cy.agorise.graphenej.api; package cy.agorise.graphenej.api;
import javax.annotation.Nullable;
import cy.agorise.graphenej.models.JsonRpcResponse; import cy.agorise.graphenej.models.JsonRpcResponse;
import okhttp3.Response; import okhttp3.Response;
@ -19,8 +21,8 @@ public interface ApiCallback {
/** /**
* Method called whenever there was an error and the response could not be delivered. * Method called whenever there was an error and the response could not be delivered.
* *
* @param t Error Trowable, potentially with some details about the problem. * @param t Error Throwable, potentially with some details about the problem.
* @param response Node response, if any * @param response Node response, if any
*/ */
void onFailure(Throwable t, Response response); void onFailure(Throwable t, @Nullable Response response);
} }

5
graphenej/src/main/java/cy/agorise/graphenej/api/android/NetworkService.java
View file

@ -565,7 +565,10 @@ public class NetworkService {
// Executing callback, if present with the parsed response // Executing callback, if present with the parsed response
if(mCallbackMap.containsKey(response.id)){ if(mCallbackMap.containsKey(response.id)){
ApiCallback callback = mCallbackMap.get(response.id); ApiCallback callback = mCallbackMap.get(response.id);
callback.onResponse(parsedResponse, text); if(response.error == null)
callback.onResponse(parsedResponse, text);
else
callback.onFailure(new Exception("Exception while trying to parse node response. Message: " + response.error.message), null);
mCallbackMap.remove(response.id); mCallbackMap.remove(response.id);
} }