agorise/graphenej
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Trying to fix a NullPointerException by checking the refeence and enclosing the whole chunk of code into a syncronized block

Browse source
This commit is contained in:
Nelson R. Perez 2018-10-15 18:35:26 -05:00
parent d25a1f3fa0
commit 36420e7f56
1 changed files with 33 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

64
graphenej/src/main/java/cy/agorise/graphenej/network/NodeLatencyVerifier.java
View file

@ -35,8 +35,6 @@ public class NodeLatencyVerifier {
private HashMap<HttpUrl, FullNode> nodeURLMap = new HashMap<>(); private HashMap<HttpUrl, FullNode> nodeURLMap = new HashMap<>();
// private WebSocket webSocket;
// Map used to store the first timestamp required for a RTT (Round Trip Time) measurement. // Map used to store the first timestamp required for a RTT (Round Trip Time) measurement.
// If: // If:
// RTT = t2 - t1 // RTT = t2 - t1
@ -104,11 +102,10 @@ public class NodeLatencyVerifier {
} }
String normalURL = fullNode.getUrl().replace("wss://", "https://"); String normalURL = fullNode.getUrl().replace("wss://", "https://");
if(!nodeURLMap.containsKey(fullNode.getUrl().replace("wss://", "https://"))){ HttpUrl key = HttpUrl.parse(normalURL);
HttpUrl key = HttpUrl.parse(normalURL); if(!nodeURLMap.containsKey(key)){
nodeURLMap.put(key, fullNode); nodeURLMap.put(key, fullNode);
} }
client.newWebSocket(request, mWebSocketListener); client.newWebSocket(request, mWebSocketListener);
} }
mHandler.postDelayed(this, verificationPeriod); mHandler.postDelayed(this, verificationPeriod);
@ -135,38 +132,43 @@ public class NodeLatencyVerifier {
* Method used to handle the node's first response. The idea here is to obtain * Method used to handle the node's first response. The idea here is to obtain
* the RTT (Round Trip Time) measurement and publish it using the PublishSubject. * the RTT (Round Trip Time) measurement and publish it using the PublishSubject.
* *
* @param webSocket Websocket instance * @param webSocket WebSocket instance
* @param response Response instance * @param response Response instance
*/ */
private void handleResponse(WebSocket webSocket, Response response){ private void handleResponse(WebSocket webSocket, Response response){
// Obtaining the HttpUrl instance that was previously used as a key synchronized (this){
HttpUrl url = webSocket.request().url(); // Obtaining the HttpUrl instance that was previously used as a key
if(nodeURLMap.containsKey(url)){ HttpUrl url = webSocket.request().url();
FullNode fullNode = nodeURLMap.get(url); if(nodeURLMap.containsKey(url)){
long delay; FullNode fullNode = nodeURLMap.get(url);
long delay;
if(response == null) { if(response == null) {
// There is no internet connection, or the node is unreachable. We are just // There is no internet connection, or the node is unreachable. We are just
// putting an artificial delay. // putting an artificial delay.
delay = Long.MAX_VALUE; delay = Long.MAX_VALUE;
} else { } else {
long after = System.currentTimeMillis(); long after = System.currentTimeMillis();
long before = timestamps.get(fullNode); long before = timestamps.get(fullNode);
delay = after - before; delay = after - before;
} }
if(fullNode != null){
fullNode.addLatencyValue(delay); fullNode.addLatencyValue(delay);
subject.onNext(fullNode); subject.onNext(fullNode);
}else{ }else{
// We cannot properly handle a response to a request whose Log.w(TAG,"Could not extract FullNode instance from the map");
// URL was not registered at the nodeURLMap. This is because without this, }
// we cannot know to which node this response corresponds. This should not happen. }else{
Log.e(TAG,"nodeURLMap does not contain url: "+url); // We cannot properly handle a response to a request whose
for(HttpUrl key : nodeURLMap.keySet()){ // URL was not registered at the nodeURLMap. This is because without this,
Log.e(TAG,"> "+key); // we cannot know to which node this response corresponds. This should not happen.
Log.e(TAG,"nodeURLMap does not contain url: "+url);
for(HttpUrl key : nodeURLMap.keySet()){
Log.e(TAG,"> "+key);
}
} }
webSocket.close(NetworkService.NORMAL_CLOSURE_STATUS, null);
} }
webSocket.close(NetworkService.NORMAL_CLOSURE_STATUS, null);
} }
}; };