From 10fa5ad679f4fe5ae78fb70ea6ebe11b4de96f54 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Schie=C3=9Fl?= Date: Fri, 27 Jul 2018 13:14:48 +0200 Subject: [PATCH] Comments from pmconrad --- bsip-0040.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/bsip-0040.md b/bsip-0040.md index b2e5808..bbaad74 100644 --- a/bsip-0040.md +++ b/bsip-0040.md @@ -12,7 +12,7 @@ # Abstract -Strengthening user security is one of the main factors to elevate BitShares. Inlight of recent +Strengthening user security is one of the main factors to elevate BitShares. In light of recent hacking and phishing attempts this becomes even more important. The need for a more sophisticated account security preceeded the idea for a finer-grained control of account permissions. We propose to add an additional authority to the account, called Custom Active (Permission). The @@ -32,19 +32,19 @@ Examples: - Proposal Update Key: Approve proposals (2FA comes to mind) - Faucet Key: Allow only to create accounts The above list of named keys is nothing that is known to the backend as the backend should have an abstract implementation. - The UI should provide a button "Create Trading Key" that properly configures the respective custom active permission entry. + The UI could provide a button "Create Trading Key" that properly configures the respective custom active permission entry. # Rational The description here is more on a superficial level and no recommendation how it can best be implemented. -Custom active permission is a list of custom active authorities. A `custom active authority` contains an `operation_id`, an `authority` (just like with active permission) and `assert`s than can be used to restricted arguments. When a transaction is signed with such an authority the backend checks if the contained operation has a corresponding custom active authority entry and if so acts as if the active authority of the corresponding account is given. It also checks if the arguments are in the allowed range. +Custom active permission is a list of custom active authorities. A `custom active authority` contains an `operation_id`, an `authority` (just like with active permission) and `assert`s than can be used to restrict arguments. When a transaction is signed with such an authority the backend checks if the contained operation has a corresponding custom active authority entry and if so acts as if the active authority of the corresponding account is given. It also checks if the arguments are in the allowed range. A Custom Active Permission looks like follows (in JSON for clarification, backend serializes and stores in a different way): ``` custom_active_permission = list of custom_active_authority items custom_active_authority = { operationid, - auhtority, + authority, assert } ``` @@ -68,7 +68,7 @@ That has the consquence now that a a transfer transaction sending funds away fro # Specifications Requirements to modify the backend includes -* Extend the account object to store custom active permission +* Extend the account object to store custom active permission that includes a list of custom active authorities. Multiple custom active authority entries are possible for one operation * Extend `account_update` or create a new operation to allow changing the custom active permission * Operation-specific authorities (if present) must be evaluated in incoming transactions * Additional committee parameters may be needed to limit the extend of usage of this feature