From 6f806db127148d165178b4d3fe2939b4c49f13ae Mon Sep 17 00:00:00 2001 From: Severiano Jaramillo Date: Sun, 17 Mar 2019 09:32:11 -0600 Subject: [PATCH] Avoid two crashlytics reported crashes due to unhandled errors in RxJava operations in the CreateAccountFragment. --- .../fragments/ConnectedFragment.kt | 2 +- .../fragments/CreateAccountFragment.kt | 15 ++++++++++++--- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/cy/agorise/bitsybitshareswallet/fragments/ConnectedFragment.kt b/app/src/main/java/cy/agorise/bitsybitshareswallet/fragments/ConnectedFragment.kt index 0e2d9c1..577fe7d 100644 --- a/app/src/main/java/cy/agorise/bitsybitshareswallet/fragments/ConnectedFragment.kt +++ b/app/src/main/java/cy/agorise/bitsybitshareswallet/fragments/ConnectedFragment.kt @@ -51,7 +51,7 @@ abstract class ConnectedFragment : Fragment(), ServiceConnection { .observeOn(AndroidSchedulers.mainThread()) .subscribe( { handleIncomingMessage(it) } , - {t -> Crashlytics.log(Log.DEBUG, TAG, t.message) } + { Crashlytics.log(Log.DEBUG, TAG, it.message) } ) ) } diff --git a/app/src/main/java/cy/agorise/bitsybitshareswallet/fragments/CreateAccountFragment.kt b/app/src/main/java/cy/agorise/bitsybitshareswallet/fragments/CreateAccountFragment.kt index 28f5bce..00a6abb 100644 --- a/app/src/main/java/cy/agorise/bitsybitshareswallet/fragments/CreateAccountFragment.kt +++ b/app/src/main/java/cy/agorise/bitsybitshareswallet/fragments/CreateAccountFragment.kt @@ -79,7 +79,10 @@ class CreateAccountFragment : BaseAccountFragment() { .skipInitialValue() .debounce(800, TimeUnit.MILLISECONDS) .observeOn(AndroidSchedulers.mainThread()) - .subscribe { validateAccountName(it.toString()) } + .subscribe( + { validateAccountName(it.toString()) }, + { Crashlytics.log(Log.DEBUG, TAG, it.message) } + ) ) // Use RxJava Debounce to update the PIN error only after the user stops writing for > 500 ms @@ -88,7 +91,10 @@ class CreateAccountFragment : BaseAccountFragment() { .skipInitialValue() .debounce(500, TimeUnit.MILLISECONDS) .observeOn(AndroidSchedulers.mainThread()) - .subscribe { validatePIN() } + .subscribe( + { validatePIN() }, + { Crashlytics.log(Log.DEBUG, TAG, it.message) } + ) ) // Use RxJava Debounce to update the PIN Confirmation error only after the user stops writing for > 500 ms @@ -97,7 +103,10 @@ class CreateAccountFragment : BaseAccountFragment() { .skipInitialValue() .debounce(500, TimeUnit.MILLISECONDS) .observeOn(AndroidSchedulers.mainThread()) - .subscribe { validatePINConfirmation() } + .subscribe( + { validatePINConfirmation() }, + { Crashlytics.log(Log.DEBUG, TAG, it.message) } + ) ) btnCancel.setOnClickListener { findNavController().navigateUp() }