From 6f132c049fd226414e3de441738e7f684d6c00f5 Mon Sep 17 00:00:00 2001
From: Severiano Jaramillo <severiano.jaramillo@gmail.com>
Date: Wed, 20 Mar 2019 21:10:32 -0600
Subject: [PATCH] Fix and standardize the material cards all around the app.

---
 app/src/main/res/layout/fragment_home.xml     |  4 ++--
 app/src/main/res/layout/fragment_settings.xml | 10 +++++-----
 app/src/main/res/layout/item_transaction.xml  | 11 +++++------
 app/src/main/res/values/dimens.xml            |  1 +
 4 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/app/src/main/res/layout/fragment_home.xml b/app/src/main/res/layout/fragment_home.xml
index 5b87e73..b1e14d5 100644
--- a/app/src/main/res/layout/fragment_home.xml
+++ b/app/src/main/res/layout/fragment_home.xml
@@ -15,7 +15,7 @@
         android:layout_marginTop="@dimen/activity_vertical_margin"
         android:layout_marginStart="@dimen/activity_horizontal_margin"
         android:layout_marginEnd="@dimen/activity_horizontal_margin"
-        app:cardElevation="4dp">
+        app:cardElevation="@dimen/card_elevation">
 
         <androidx.constraintlayout.widget.ConstraintLayout
             android:layout_width="match_parent"
@@ -168,7 +168,7 @@
         android:layout_marginStart="@dimen/activity_horizontal_margin"
         android:layout_marginEnd="@dimen/activity_horizontal_margin"
         android:layout_weight="2"
-        app:cardElevation="4dp">
+        app:cardElevation="@dimen/card_elevation">
 
         <LinearLayout
             android:layout_width="match_parent"
diff --git a/app/src/main/res/layout/fragment_settings.xml b/app/src/main/res/layout/fragment_settings.xml
index 32c0852..dfcf401 100644
--- a/app/src/main/res/layout/fragment_settings.xml
+++ b/app/src/main/res/layout/fragment_settings.xml
@@ -23,7 +23,7 @@
             android:layout_marginStart="@dimen/activity_horizontal_margin"
             android:layout_marginEnd="@dimen/activity_horizontal_margin"
             app:contentPadding="@dimen/activity_vertical_margin"
-            app:cardElevation="2dp"
+            app:cardElevation="@dimen/card_elevation"
             app:cardCornerRadius="@dimen/card_radius">
 
             <LinearLayout
@@ -82,7 +82,7 @@
             android:layout_marginStart="@dimen/activity_horizontal_margin"
             android:layout_marginEnd="@dimen/activity_horizontal_margin"
             app:contentPadding="@dimen/activity_vertical_margin"
-            app:cardElevation="2dp"
+            app:cardElevation="@dimen/card_elevation"
             app:cardCornerRadius="@dimen/card_radius">
 
             <LinearLayout
@@ -127,7 +127,7 @@
             android:layout_marginStart="@dimen/activity_horizontal_margin"
             android:layout_marginEnd="@dimen/activity_horizontal_margin"
             app:contentPadding="@dimen/activity_vertical_margin"
-            app:cardElevation="2dp"
+            app:cardElevation="@dimen/card_elevation"
             app:cardCornerRadius="@dimen/card_radius">
 
             <LinearLayout
@@ -171,7 +171,7 @@
             android:layout_marginStart="@dimen/activity_horizontal_margin"
             android:layout_marginEnd="@dimen/activity_horizontal_margin"
             app:contentPadding="@dimen/activity_vertical_margin"
-            app:cardElevation="2dp"
+            app:cardElevation="@dimen/card_elevation"
             app:cardCornerRadius="@dimen/card_radius">
 
             <LinearLayout
@@ -216,7 +216,7 @@
             android:layout_marginStart="@dimen/activity_horizontal_margin"
             android:layout_marginEnd="@dimen/activity_horizontal_margin"
             app:contentPadding="@dimen/activity_vertical_margin"
-            app:cardElevation="2dp"
+            app:cardElevation="@dimen/card_elevation"
             app:cardCornerRadius="@dimen/card_radius">
 
             <LinearLayout
diff --git a/app/src/main/res/layout/item_transaction.xml b/app/src/main/res/layout/item_transaction.xml
index 2e50971..ce52259 100644
--- a/app/src/main/res/layout/item_transaction.xml
+++ b/app/src/main/res/layout/item_transaction.xml
@@ -1,14 +1,13 @@
 <?xml version="1.0" encoding="utf-8"?>
 <androidx.cardview.widget.CardView
-    xmlns:card_view="http://schemas.android.com/apk/res-auto"
     xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     android:layout_gravity="center"
-    card_view:cardElevation="4dp"
-    card_view:cardCornerRadius="@dimen/card_radius"
+    app:cardElevation="@dimen/card_elevation"
+    app:cardCornerRadius="@dimen/card_radius"
     android:layout_margin="@dimen/card_margin">
 
     <androidx.constraintlayout.widget.ConstraintLayout
@@ -114,9 +113,9 @@
             android:layout_height="wrap_content"
             android:orientation="vertical"
             android:visibility="gone"
-            card_view:layout_constraintTop_toBottomOf="@id/vSeparator"
-            card_view:layout_constraintStart_toEndOf="@id/firstVerticalGuideline"
-            card_view:layout_constraintEnd_toStartOf="@id/fourthVerticalGuideline">
+            app:layout_constraintTop_toBottomOf="@id/vSeparator"
+            app:layout_constraintStart_toEndOf="@id/firstVerticalGuideline"
+            app:layout_constraintEnd_toStartOf="@id/fourthVerticalGuideline">
 
             <TextView
                 android:id="@+id/tvMemo"
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
index aeaa1e5..28c704b 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -19,6 +19,7 @@
     <dimen name="logo_size">180dp</dimen>
 
     <!-- Transactions -->
+    <dimen name="card_elevation">6dp</dimen>
     <dimen name="card_margin">4dp</dimen>
     <dimen name="card_radius">4dp</dimen>