agorise/bitsy-wallet
agorise/bitsy-wallet
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity

Fix crash in BalancesFragment.

Browse source 
- The crash was happening in a very weird scenario, but it was good because it forced us to search an alternative to update the BalancesFragment when the user navigates back to the HomeFragment. The solution was to use the childFragmentManager instead of the fragmentManager to create the PagerAdapter used in the ViewPager that displays the BalancesFragment. Basically, because we are using nested fragments we need to use the childFragmentManager instead of just the fragmentManager, to use the correct LyfeCycle events.
This commit is contained in:
Severiano Jaramillo 2019-08-21 15:09:59 -05:00
parent 6482b31971
commit 31073e2acf
3 changed files with 1 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/src/main/java/cy/agorise/bitsybitshareswallet/fragments/BalancesFragment.kt
View file

@ -43,12 +43,4 @@ class BalancesFragment: Fragment() {
balancesAdapter.replaceAll(balancesDetails) balancesAdapter.replaceAll(balancesDetails)
}) })
} }
override fun setUserVisibleHint(isVisibleToUser: Boolean) {
super.setUserVisibleHint(isVisibleToUser)
if (isVisibleToUser) {
// TODO find a better way to recreate the fragment, that does it only when the theme has been changed
fragmentManager?.beginTransaction()?.detach(this)?.attach(this)?.commit()
}
}
} }

2
app/src/main/java/cy/agorise/bitsybitshareswallet/fragments/HomeFragment.kt
View file

@ -112,7 +112,7 @@ class HomeFragment : Fragment() {
} }
// Configure ViewPager with PagerAdapter and TabLayout to display the Balances/NetWorth section // Configure ViewPager with PagerAdapter and TabLayout to display the Balances/NetWorth section
val pagerAdapter = PagerAdapter(fragmentManager!!) val pagerAdapter = PagerAdapter(childFragmentManager)
viewPager.adapter = pagerAdapter viewPager.adapter = pagerAdapter
tabLayout.setupWithViewPager(viewPager) tabLayout.setupWithViewPager(viewPager)
// Set the pie chart icon for the third tab // Set the pie chart icon for the third tab

8
app/src/main/java/cy/agorise/bitsybitshareswallet/fragments/NetWorthFragment.kt
View file

@ -17,12 +17,4 @@ class NetWorthFragment: Fragment() {
return inflater.inflate(R.layout.fragment_net_worth, container, false) return inflater.inflate(R.layout.fragment_net_worth, container, false)
} }
override fun setUserVisibleHint(isVisibleToUser: Boolean) {
super.setUserVisibleHint(isVisibleToUser)
if (isVisibleToUser) {
// TODO find a better way to recreate the fragment, that does it only when the theme has been changed
fragmentManager?.beginTransaction()?.detach(this)?.attach(this)?.commit()
}
}
} }