From 20571d49a324b0a4b25c1d09caa46e5e5980caaf Mon Sep 17 00:00:00 2001 From: Severiano Jaramillo Date: Mon, 6 Jan 2020 08:52:42 -0600 Subject: [PATCH] Fix crash in NetworkServiceManager. - Fixed a crash in NetworkServiceManager, which is listening to the activities' lifecycle of the whole app. The issue is that it was expecting a call to onActivityCreated where the Bundle was never null and that is a problem because the Bundle can most of the times be null during normal behavior. The Bundle isn't null only when the app is recovering from a forced process dead, which happens when there is another app open which requires resources and the systems kills apps that are not being used at that moment. --- .../network/NetworkServiceManager.kt | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/app/src/main/java/cy/agorise/bitsybitshareswallet/network/NetworkServiceManager.kt b/app/src/main/java/cy/agorise/bitsybitshareswallet/network/NetworkServiceManager.kt index 8e227b0..006ba22 100644 --- a/app/src/main/java/cy/agorise/bitsybitshareswallet/network/NetworkServiceManager.kt +++ b/app/src/main/java/cy/agorise/bitsybitshareswallet/network/NetworkServiceManager.kt @@ -33,7 +33,7 @@ class NetworkServiceManager(nodes: List) : } } - override fun onActivityCreated(activity: Activity, bundle: Bundle) {} + override fun onActivityCreated(activity: Activity, bundle: Bundle?) {} override fun onActivityStarted(activity: Activity) {} override fun onActivityResumed(activity: Activity?) { mHandler.removeCallbacks(mDisconnectRunnable) @@ -51,12 +51,7 @@ class NetworkServiceManager(nodes: List) : } override fun onActivityStopped(activity: Activity) {} - override fun onActivitySaveInstanceState( - activity: Activity, - bundle: Bundle - ) { - } - + override fun onActivitySaveInstanceState(activity: Activity, bundle: Bundle) {} override fun onActivityDestroyed(activity: Activity) {} companion object {