From 1a13f39cf6a48fc8787f6e117cf06dcdedc702e0 Mon Sep 17 00:00:00 2001 From: squishyhuman Date: Thu, 19 Jan 2017 11:26:57 -0800 Subject: [PATCH 1/2] Fix use of uninitialized variable --- dnslink/dnslink.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/dnslink/dnslink.c b/dnslink/dnslink.c index 1ced40a..06f451d 100644 --- a/dnslink/dnslink.c +++ b/dnslink/dnslink.c @@ -144,6 +144,7 @@ int ipfs_dns (int argc, char **argv) free (*txt); free (txt); free (param); + param = path; if (! r) { // not recursive. @@ -153,11 +154,9 @@ int ipfs_dns (int argc, char **argv) if (memcmp(path, "/ipfs/", 6) == 0) { break; } - - param = path; } while (--r); - fprintf (stdout, "%s\n", path); - free (path); + fprintf (stdout, "%s\n", param); + free (param); return 0; } From 929bc07168c204dcea29e00db07d7c0a591f0226 Mon Sep 17 00:00:00 2001 From: squishyhuman Date: Thu, 19 Jan 2017 12:25:48 -0800 Subject: [PATCH 2/2] Fix possible memory leak --- dnslink/dnslink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dnslink/dnslink.c b/dnslink/dnslink.c index 06f451d..fbcf3b0 100644 --- a/dnslink/dnslink.c +++ b/dnslink/dnslink.c @@ -128,6 +128,8 @@ int ipfs_dns (int argc, char **argv) } else { err = ipfs_dnslink_resolv_lookupTXT (&txt, param); } + free (param); + if (err) { fprintf (stderr, "dns lookupTXT: %s\n", Err[err]); return err; @@ -143,7 +145,6 @@ int ipfs_dns (int argc, char **argv) free (*txt); free (txt); - free (param); param = path; if (! r) {